Support using container entrypoints for shell tasks #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
===========================================
- Coverage 87.89% 57.64% -30.26%
===========================================
Files 84 84
Lines 17890 17907 +17
Branches 3483 1556 -1927
===========================================
- Hits 15725 10323 -5402
- Misses 1809 7399 +5590
+ Partials 356 185 -171 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tclose
force-pushed
the
container-entrypoint
branch
from
dd382ca to
d7a9b2a
Compare
tclose
force-pushed
the
container-entrypoint
branch
from
6f08e7b to
38a1db8
Compare
…handling performed in Environment.execute
tclose
force-pushed
the
container-entrypoint
branch
from
38a1db8 to
b913f30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Summary
When executing shell commands in Docker/Singularity containers, permit setting
executableto None in order to use the entrypoint of the container.Checklist